linux-kernel - Re: [PATCH V2] scsi: ufs: add support for query requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f618017941695cac811fc9c960874c4.squirrel@www.codeaurora.org>
Date:	Thu, 18 Apr 2013 01:24:14 -0700
From:	"Dolev Raviv" <draviv@...eaurora.org>
To:	"Dolev Raviv" <draviv@...eaurora.org>
Cc:	linux-scsi@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	"Dolev Raviv" <draviv@...eaurora.org>,
	"open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] scsi: ufs: add support for query requests

Hi All,

A minor bug was spotted, as shown blow. The fix will be submitted with the
next version.

> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp)
> +{
> +	u32 upiu_flags;
> +	int ret = 0;
> +
> +	if (!lrbp) {
> +		dev_err(hba->dev, "%s: lrbp can not be NULL\n", __func__);
> +		ret = -EINVAL;
> +	} else if (!lrbp->ucd_req_ptr) {
> +		dev_err(hba->dev, "%s: ucd_req_ptr can not be NULL\n",
> +			__func__);
> +		ret = -EINVAL;
> +	} else if (!lrbp->utr_descriptor_ptr) {
> +		dev_err(hba->dev, "%s: utr_descriptor_ptr can not be NULL\n",
> +			__func__);
> +		ret = -EINVAL;
> +	}
> +	if (!ret)
> +		goto exit;
should be:
if (ret)

Thanks,
Dolev

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/