[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <517110BA.5070806@asianux.com>
Date: Fri, 19 Apr 2013 17:39:06 +0800
From: Chen Gang <gang.chen@...anux.com>
To: Eric Paris <eparis@...hat.com>, Al Viro <viro@...iv.linux.org.uk>
CC: Andrew Morton <akpm@...ux-foundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] kernel/audit_tree.c: tree will memory leak when failure occurs
for audit_trim_trees()
in audit_trim_trees(), has called get_tree() before failure occurs,
so need also call put_tree after go to skip_it:
Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
kernel/audit_tree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index 642a89c..de46ec0 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -617,10 +617,10 @@ void audit_trim_trees(void)
}
spin_unlock(&hash_lock);
trim_marked(tree);
- put_tree(tree);
drop_collected_mounts(root_mnt);
skip_it:
mutex_lock(&audit_filter_mutex);
+ put_tree(tree);
}
list_del(&cursor);
mutex_unlock(&audit_filter_mutex);
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists