linux-kernel - Re: [PATCH wireless-next V2] rt2x00: Use more current logging styles, shrink object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51718D24.3020902@gmail.com>
Date:	Fri, 19 Apr 2013 20:29:56 +0200
From:	Gertjan van Wingerde <gwingerde@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Ivo van Doorn <IvDoorn@...il.com>,
	Helmut Schaa <helmut.schaa@...glemail.com>,
	"John W. Linville" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	rt2x00 Users List <users@...x00.serialmonkey.com>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless-next V2] rt2x00: Use more current logging styles,
 shrink object size

On 04/19/13 17:33, Joe Perches wrote:
> Reduce object space ~2% using more current logging styles.
> 
> Neaten and simplify logging macros.
> Use wiphy_<level> where appropriate.
> Coalesce formats.
> 
> Convert ERROR/WARNING/INFO macros to rt2x00_<level>
> Convert EEPROM to rt2x00_eeprom_dbg
> Convert PROBE_ERROR to rt2x00_probe_err
> Convert DEBUG to rt2x00_dbg
> Convert EEPROM to rt2x00_eeprom_dbg
> 
> $ size drivers/net/wireless/rt2x00/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>  245639	  71696	  69584	 386919	  5e767	drivers/net/wireless/rt2x00/built-in.o.new
>  240609	  70096	  68944	 379649	  5cb01	drivers/net/wireless/rt2x00/built-in.o.new.nodyndbg
>  240609	  70096	  68944	 379649	  5cb01	drivers/net/wireless/rt2x00/built-in.o.new.no_rt2x00_debug
>  249198	  70096	  70352	 389646	  5f20e	drivers/net/wireless/rt2x00/built-in.o.old
>  249198	  70096	  70352	 389646	  5f20e	drivers/net/wireless/rt2x00/built-in.o.old.nodyndbg
>  244222	  70096	  69712	 384030	  5dc1e	drivers/net/wireless/rt2x00/built-in.o.old.no_rt2x00_debug
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Gertjan van Wingerde <gwingerde@...il.com>

> ---
> V2 differences:
> 
> Correct copy/paste error in rt2x00_info/warn macros
> Reorder macro definitions
> Use embedded prefix in rt2x00_eeprom_dbg
> 
> Object size increased from v1 ~100 bytes x86/32.
> Object size may be slightly smaller this way for x86/64
> 
>
---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/