linux-kernel - Re: [PATCH] e1000e: fix mismatch in mutex lock-unlock in e1000_reset_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1366353879.15587.4.camel@jtkirshe-mobl>
Date:	Thu, 18 Apr 2013 23:44:39 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Alex Duyck <alexander.h.duyck@...el.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] e1000e: fix mismatch in mutex lock-unlock in
 e1000_reset_hw_82571()

On Thu, 2013-04-18 at 22:15 -0700, Alexey Khoroshilov wrote:
> If e1000_get_hw_semaphore_82574() succeed, it acquires swflag_mutex,
> otherwise it does not. But the returned value of
> e1000_get_hw_semaphore_82574() is ignored, so unlocking of
> swflag_mutex
> happens anyway.
> 
> The patch fixes the issue by breaking reset if MIC ownership is not
> acquired.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> ---
>  drivers/net/ethernet/intel/e1000e/82571.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-) 

Thanks Alexey, I have added your patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)