linux-kernel - Re: [PATCH] signal: stop info leak via the tkill and the tgkill syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130420221442.GB25043@austin.hallyn.com>
Date:	Sat, 20 Apr 2013 17:14:42 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	PaX Team <pageexec@...email.hu>,
	Emese Revfy <re.emese@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] signal: stop info leak via the tkill and the tgkill
 syscalls

Quoting Kees Cook (keescook@...omium.org):
> From: Emese Revfy <re.emese@...il.com>
> 
> This fixes a kernel memory contents leak via the tkill and tgkill syscalls
> for compat processes.
> 
> This is visible in the siginfo_t->_sifields._rt.si_sigval.sival_ptr field
> when handling signals delivered from tkill.
> 
> The place of the infoleak:
> 
> int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
> {
>         ...
>         put_user_ex(ptr_to_compat(from->si_ptr), &to->si_ptr);
>         ...
> }
> 
> Signed-off-by: Emese Revfy <re.emese@...il.com>

Sorry, not sure if this is applied yet,

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> Reviewed-by: PaX Team <pageexec@...email.hu>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Cc: stable@...r.kernel.org
> ---
>  kernel/signal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index dd72567..598dc06 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2948,7 +2948,7 @@ do_send_specific(pid_t tgid, pid_t pid, int sig, struct siginfo *info)
>  
>  static int do_tkill(pid_t tgid, pid_t pid, int sig)
>  {
> -	struct siginfo info;
> +	struct siginfo info = {};
>  
>  	info.si_signo = sig;
>  	info.si_errno = 0;
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/