linux-kernel - Re: [PATCH] perf, x86: Fix some broken initconsts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130421095626.GA10683@gmail.com>
Date:	Sun, 21 Apr 2013 11:56:26 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>,
	Jan Beulich <jbeulich@...e.com>
Subject: Re: [PATCH] perf, x86: Fix some broken initconsts


* Andi Kleen <andi@...stfloor.org> wrote:

> From: Andi Kleen <ak@...ux.intel.com>
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> 
> diff --git a/arch/x86/kernel/cpu/perf_event_knc.c b/arch/x86/kernel/cpu/perf_event_knc.c
> index 4b7731b..2cfe648 100644
> --- a/arch/x86/kernel/cpu/perf_event_knc.c
> +++ b/arch/x86/kernel/cpu/perf_event_knc.c
> @@ -17,7 +17,7 @@ static const u64 knc_perfmon_event_map[] =
>    [PERF_COUNT_HW_BRANCH_MISSES]		= 0x002b,
>  };
>  
> -static __initconst u64 knc_hw_cache_event_ids
> +static __initconst const u64 knc_hw_cache_event_ids
>  				[PERF_COUNT_HW_CACHE_MAX]
>  				[PERF_COUNT_HW_CACHE_OP_MAX]
>  				[PERF_COUNT_HW_CACHE_RESULT_MAX] =
> @@ -284,7 +284,7 @@ static struct attribute *intel_knc_formats_attr[] = {
>  	NULL,
>  };
>  
> -static __initconst struct x86_pmu knc_pmu = {
> +static __initconst const struct x86_pmu knc_pmu = {
>  	.name			= "knc",
>  	.handle_irq		= knc_pmu_handle_irq,
>  	.disable_all		= knc_pmu_disable_all,

Already fixed in:

  c391c7884633 x86: Constify a few items

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/