linux-kernel - Re: irq 16: nobody cared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzjwq53ec.wl%tiwai@suse.de>
Date:	Mon, 22 Apr 2013 11:19:07 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Borislav Petkov <bp@...en8.de>
Cc:	paulmck@...ux.vnet.ibm.com, x86-ml <x86@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: irq 16: nobody cared

At Mon, 22 Apr 2013 11:13:10 +0200,
Borislav Petkov wrote:
> 
> On Mon, Apr 22, 2013 at 10:32:17AM +0200, Takashi Iwai wrote:
> > Hm, if it's really due to a stray irq, just adding the missing
> > synchronize_irq() like below would help?
> > 
> > 
> > Takashi
> > 
> > ---
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 7b213d5..262dbf1 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2682,6 +2682,8 @@ static void azx_stop_chip(struct azx *chip)
> >  	/* disable interrupts */
> >  	azx_int_disable(chip);
> >  	azx_int_clear(chip);
> > +	if (chip->irq >= 0)
> > +		synchronize_irq(chip->irq);
> 
> Nope, it doesn't help - I see the same splat.

Thanks.  Then I have no idea what's missing in the current
azx_suspend() and azx_resume() codes.

Is the PCI device a HD-audio controller for the built-in analog or
a HDMI audio controller coupled with a graphics chip?

I wonder why no MSI is used there.  MSI should have been used for most
of controllers except for cases where blacklisted with PCI SSID or
Nvidia / Creative controllers.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/