lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Apr 2013 15:08:44 +0530 From: Vinod Koul <vinod.koul@...el.com> To: Lee Jones <lee.jones@...aro.org> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, arnd@...db.de, linus.walleij@...ricsson.com, Dan Williams <djbw@...com>, Per Forlin <per.forlin@...ricsson.com>, Rabin Vincent <rabin@....in> Subject: Re: [PATCH 22/32] dmaengine: ste_dma40: Allocate plat_data on declaration On Thu, Apr 18, 2013 at 11:12:04AM +0100, Lee Jones wrote: > It's the way that most other drivers do it. > > Very trivial clean-up which reduces line count and simplifies code. > > Cc: Vinod Koul <vinod.koul@...el.com> > Cc: Dan Williams <djbw@...com> > Cc: Per Forlin <per.forlin@...ricsson.com> > Cc: Rabin Vincent <rabin@....in> > Signed-off-by: Lee Jones <lee.jones@...aro.org> Acked-by: Vinod Koul <vnod.koul@...el.com> -- ~Vinod > --- > drivers/dma/ste_dma40.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 805049c..6f9f801 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -3119,7 +3119,7 @@ static int __init d40_phy_res_init(struct d40_base *base) > > static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev) > { > - struct stedma40_platform_data *plat_data; > + struct stedma40_platform_data *plat_data = pdev->dev.platform_data; > struct clk *clk = NULL; > void __iomem *virtbase = NULL; > struct resource *res = NULL; > @@ -3190,8 +3190,6 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev) > goto failure; > } > > - plat_data = pdev->dev.platform_data; > - > /* The number of physical channels on this HW */ > if (plat_data->num_of_phy_chans) > num_phy_chans = plat_data->num_of_phy_chans; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists