linux-kernel - Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51750DCB.3060306@free-electrons.com>
Date:	Mon, 22 Apr 2013 12:15:39 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Juergen Beisert <jbe@...gutronix.de>
CC:	linux-arm-kernel@...ts.infradead.org,
	Shawn Guo <shawn.guo@...aro.org>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Marek Vasut <marex@...x.de>, linux-fbdev@...r.kernel.org,
	Brian Lilly <brian@...stalfontz.com>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Thomas Petazzoni <thomas@...e-electrons.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-kernel@...r.kernel.org,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Subject: Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color
 depth

Hi Juergen,

Le 22/04/2013 11:08, Juergen Beisert a écrit :
> Hi Maxime,
> 
> Maxime Ripard wrote:
>> The current code always registers as a 32 bits display, and uses the
>> hardware to drop the MSB of each color to abjust to the interface width
>> used by the panel.
>>
>> This results on 18 bits (and probably 16 bits display as well) in colors
>> being displayed poorly, because the MSB are obviously the most important
>> bits for each color definition.
> 
> But the "def_rgb666" bitfield description reports correctly to use bit 0..5 
> for each colour component in this mode. Maybe your userland program has a bug 
> and forgets to honor the bitfield description?

Hmmm, that might be the case actually, yes, I'll check into this and let
you know. Thanks!

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/