linux-kernel - Re: [PATCH 1/8] sysrq: fix inconstistent help message of sysrq key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51752241.40701@huawei.com>
Date:	Mon, 22 Apr 2013 19:42:57 +0800
From:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
To:	Randy Dunlap <rdunlap@...radead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/8] sysrq: fix inconstistent help message of sysrq key

On 2013/3/8 4:14, Randy Dunlap wrote:
> On 03/07/13 01:00, zhangwei(Jovi) wrote:
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>>       SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>>       memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix it.
>>
>> Thanks the comments from Andrew and Randy.
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@...wei.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Randy Dunlap <rdunlap@...radead.org>
> 
> for the patch series (1-8):
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Thanks.
> 
Andrew, Could you pick up the other patches(2,3,4,5,7,8) into your -mm tree?
first patch was already merged by Grey.

Thanks.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/