linux-kernel - Re: [PATCH v2 2/6] sched: explicitly cpu_idle_type checking in rebalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366631983.4443.11.camel@laptop>
Date:	Mon, 22 Apr 2013 13:59:43 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/6] sched: explicitly cpu_idle_type checking in
 rebalance_domains()

On Tue, 2013-03-26 at 15:01 +0900, Joonsoo Kim wrote:
> @@ -5506,10 +5506,10 @@ static void rebalance_domains(int cpu, enum
> cpu_idle_type idle)
>                 if (time_after_eq(jiffies, sd->last_balance +
> interval)) {
>                         if (load_balance(cpu, rq, sd, idle, &balance))
> {
>                                 /*
> -                                * We've pulled tasks over so either
> we're no
> -                                * longer idle.
> +                                * We've pulled tasks over so either
> we may
> +                                * be no longer idle.
>                                  */

That comment didn't make sense and it does even less now.

How about we make that:

  /*
   * The LBF_SOME_PINNED logic could have changed
   * env->dst_cpu, so we can't know our idle state
   * even if we migrated tasks; update it.
   */

> -                               idle = CPU_NOT_IDLE;
> +                               idle = idle_cpu(cpu) ? CPU_IDLE :
> CPU_NOT_IDLE;
>                         }
>                         sd->last_balance = jiffies;
>                 }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/