linux-kernel - Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1366591846.3408.126.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 22 Apr 2013 01:50:46 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	Jonghwan Choi <jhbird.choi@...sung.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	'Zhang Rui' <rui.zhang@...el.com>,
	'Richard Guy Briggs' <rbriggs@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3.8-stable] thermal: return an error on failure to
 register thermal

On Wed, 2013-04-03 at 15:47 +0100, Luis Henriques wrote:
> On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> > 3.8-stable review patch.  If anyone has any objections, please let me know.
> 
> I believe this is applicable to all the other stable kernels.

Queued up for 3.2, thanks.

Ben.

> Cheers,
> --
> Luis
> 
> > 
> > ------------------
> > 
> > From: "Richard Guy Briggs <rbriggs@...hat.com>"
> > 
> > commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> > 
> > The return code from the registration of the thermal class is used to
> > unallocate resources, but this failure isn't passed back to the caller of
> > thermal_init.  Return this failure back to the caller.
> > 
> > This bug was introduced in changeset 4cb18728 which overwrote the return
> > code
> > when the variable was re-used to catch the return code of the registration
> > of
> > the genetlink thermal socket family.
> > 
> > Signed-off-by: Richard Guy Briggs <rbriggs@...hat.com>
> > Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> > ---
> >  drivers/thermal/thermal_sys.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 6472e7e..1a19a2f 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -1875,6 +1875,7 @@ static int __init thermal_init(void)
> >  		idr_destroy(&thermal_cdev_idr);
> >  		mutex_destroy(&thermal_idr_lock);
> >  		mutex_destroy(&thermal_list_lock);
> > +		return result;
> >  	}
> >  	result = genetlink_init();
> >  	return result;
> > -- 
> > 1.7.9.5
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe stable" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)