linux-kernel - Re: [PATCH V2] usb: storage: Convert US_DEBUGP to usb_stor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1304221234270.16385@chino.kir.corp.google.com>
Date:	Mon, 22 Apr 2013 12:35:26 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Joe Perches <joe@...ches.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb <linux-usb@...r.kernel.org>,
	usb-storage <usb-storage@...ts.one-eyed-alien.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] usb: storage: Convert US_DEBUGP to usb_stor_dbg

On Fri, 19 Apr 2013, Joe Perches wrote:

> @@ -966,11 +934,13 @@ static int realtek_cr_autosuspend_setup(struct us_data *us)
>  static void realtek_cr_destructor(void *extra)
>  {
>  	struct rts51x_chip *chip = (struct rts51x_chip *)extra;
> -
> -	US_DEBUGP("%s: <---\n", __func__);
> +	struct us_data *us;
>  
>  	if (!chip)
>  		return;
> +
> +	us = chip->us;
> +
>  #ifdef CONFIG_REALTEK_AUTOPM
>  	if (ss_en) {
>  		del_timer(&chip->rts51x_suspend_timer);

>From linux-next:

drivers/usb/storage/realtek_cr.c: In function 'realtek_cr_destructor':
drivers/usb/storage/realtek_cr.c:942:11: error: 'struct rts51x_chip' has no member named 'us'

chip->us here is only defined when CONFIG_REALTEK_AUTOPM is enabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/