linux-kernel - Re: [PATCH]drivers:acpi: Fix wrong parameter passed to memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97631249.RDz9BWEgHg@vostro.rjw.lan>
Date:	Tue, 23 Apr 2013 01:31:04 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Wang YanQing <udknight@...il.com>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH]drivers:acpi: Fix wrong parameter passed to memblock_reserve

On Friday, April 19, 2013 12:40:46 PM Wang YanQing wrote:
> On Mon, Apr 15, 2013 at 07:47:38PM -0700, Yinghai Lu wrote:
> > On Mon, Apr 15, 2013 at 6:44 PM, Wang YanQing <udknight@...il.com> wrote:
> > >
> > > The parameter of memblock_reserve is start address,
> > > and size, not address range.
> > >
> > > Signed-off-by: Wang YanQing <udknight@...il.com>
> > > ---
> > >  drivers/acpi/osl.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > > index 586e7e9..bcb7a3b 100644
> > > --- a/drivers/acpi/osl.c
> > > +++ b/drivers/acpi/osl.c
> > > @@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)
> > >          * Both memblock_reserve and e820_add_region (via arch_reserve_mem_area)
> > >          * works fine.
> > >          */
> > > -       memblock_reserve(acpi_tables_addr, acpi_tables_addr + all_tables_size);
> > > +       memblock_reserve(acpi_tables_addr, all_tables_size);
> > >         arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
> > 
> > Acked-by: Yinghai Lu <yinghai@...nel.org>
> > 
> > And it should go to stable for v3.8
> 
> Hi all, I think this fix should be merged before 3.9 is out,
> it make no much sense to backport it for 3.9 later, but we don't have 
> much time before 3.9 is out, so...
> 
> Thanks.

Applied, but please send ACPI patches (and especially urgent fixes) to
linux-acpi@...r.kernel.org in the future.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/