linux-kernel - Re: [next:akpm 798/1000] drivers/rtc/rtc-ds1286.c:343:24: sparse: incorrect type in argument 1 (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130422165629.bae79e6c5251bf148a3bae73@linux-foundation.org>
Date:	Mon, 22 Apr 2013 16:56:29 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Jingoo Han <jg1.han@...sung.com>, kbuild-all@...org,
	linux-sparse@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [next:akpm 798/1000] drivers/rtc/rtc-ds1286.c:343:24: sparse:
 incorrect type in argument 1 (different address spaces)

On Sat, 20 Apr 2013 07:54:34 +0800 kbuild test robot <fengguang.wu@...el.com> wrote:

> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> head:   c9941b7ec7840ad33f5822c7f238157558d40132
> commit: d5e42b5769899607e1e4b0c9200340d24f370e8c [798/1000] rtc: rtc-ds1286: use devm_*() functions
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/rtc/rtc-ds1286.c:343:24: sparse: incorrect type in argument 1 (different address spaces)
>    drivers/rtc/rtc-ds1286.c:343:24:    expected void const *ptr
>    drivers/rtc/rtc-ds1286.c:343:24:    got unsigned int [noderef] [usertype] <asn:2>*rtcregs
> >> drivers/rtc/rtc-ds1286.c:344:36: sparse: incorrect type in argument 1 (different address spaces)
>    drivers/rtc/rtc-ds1286.c:344:36:    expected void const *ptr
>    drivers/rtc/rtc-ds1286.c:344:36:    got unsigned int [noderef] [usertype] <asn:2>*rtcregs
> 
> vim +343 drivers/rtc/rtc-ds1286.c
> 
>    337			return -ENODEV;
>    338		priv = devm_kzalloc(&pdev->dev, sizeof(struct ds1286_priv), GFP_KERNEL);
>    339		if (!priv)
>    340			return -ENOMEM;
>    341	
>    342		priv->rtcregs = devm_ioremap_resource(&pdev->dev, res);
>  > 343		if (IS_ERR(priv->rtcregs))
>  > 344			return PTR_ERR(priv->rtcregs);
>    345	
>    346		spin_lock_init(&priv->lock);
>    347		platform_set_drvdata(pdev, priv);

I think doing IS_ERR() and PTR_ERR() on __iomem pointers is a natural
thing, and we should be able to do this without adding call-site
trickery to make sparse happy.

Is there some sort of annotation which we can add to the
IS_ERR()/PTR_ERR() definitions so that sparse will stop warning about
this usage?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/