linux-kernel - Re: [RFC PATCH 1/2] regulator: core: Add regulator_set_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130423084838.GB5019@opensource.wolfsonmicro.com>
Date:	Tue, 23 Apr 2013 09:48:39 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Taras Kondratiuk <taras@...com>
Cc:	lgirdwood@...il.com, rjw@...k.pl, viresh.kumar@...aro.org,
	shawn.guo@...aro.org, cpufreq@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Philip Rakity <prakity@...dia.com>,
	Eric Miao <eric.y.miao@...il.com>
Subject: Re: [RFC PATCH 1/2] regulator: core: Add regulator_set_voltage_min()

On Mon, Apr 22, 2013 at 07:49:37PM +0300, Taras Kondratiuk wrote:

> Yeah. Sure 4kV is not a real request, but
> max will be limited by system constrains.
> According to regulator_set_voltage() documentation
> system constraints should be set before calling this function,
> so I assume I can rely on them. No?

> Another possible implementation is below, but prefer initial one.

I just don't see any reason for this API.  The driver setting the
voltage ought to have some idea of what the chip limits are too for
safety.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)