linux-kernel - Re: [RESEND][PATCH RFT 2/2] pwm: lpc32xx: Don't change PWM_ENABLE bit in lpc32xx_pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Apr 2013 10:51:32 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	Alexandre Pereira da Silva <aletes.xgr@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH RFT 2/2] pwm: lpc32xx: Don't change PWM_ENABLE
 bit in lpc32xx_pwm_config

On 04/23/2013 08:02 AM, Axel Lin wrote:
> lpc32xx_pwm_config() is supposed to set duty_ns and period_ns,
> it should not change PWM_ENABLE bit.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Tested-by: Roland Stigge <stigge@...com.de>

> ---
>  drivers/pwm/pwm-lpc32xx.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c
> index 1a5075e..e936202 100644
> --- a/drivers/pwm/pwm-lpc32xx.c
> +++ b/drivers/pwm/pwm-lpc32xx.c
> @@ -37,6 +37,7 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
>  	struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
>  	unsigned long long c;
>  	int period_cycles, duty_cycles;
> +	u32 val;
>  
>  	c = clk_get_rate(lpc32xx->clk) / 256;
>  	c = c * period_ns;
> @@ -68,8 +69,10 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
>  		c = 255;
>  	duty_cycles = 256 - c;
>  
> -	writel(PWM_ENABLE | PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles),
> -		lpc32xx->base + (pwm->hwpwm << 2));
> +	val = readl(lpc32xx->base + (pwm->hwpwm << 2));
> +	val &= ~0xFFFF;
> +	val |= PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles);
> +	writel(val, lpc32xx->base + (pwm->hwpwm << 2));
>  
>  	return 0;
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/