linux-kernel - Re: [PATCH 3.8-stable] perf: Fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130423105659.GE3471@hercules>
Date:	Tue, 23 Apr 2013 11:56:59 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Jonghwan Choi <jhbird.choi@...sung.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	'Wei Yongjun' <yongjun_wei@...ndmicro.com.cn>,
	'Peter Zijlstra' <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 3.8-stable] perf: Fix error return code

On Tue, Apr 23, 2013 at 11:57:51AM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch.  If anyone has any objections, please let me know.

Thanks, I believe this is also applicable to 3.2.y, 3.4.y and 3.5.y.

Cheers,
--
Luis

> 
> ------------------
> 
> From: "Wei Yongjun <yongjun_wei@...ndmicro.com.cn>"
> 
> commit c481420248c6730246d2a1b1773d5d7007ae0835 upstream.
> 
> Fix to return -ENOMEM in the allocation error case instead of 0
> (if pmu_bus_running == 1), as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> Cc: a.p.zijlstra@...llo.nl
> Cc: paulus@...ba.org
> Cc: acme@...stprotocols.net
> Link:
> http://lkml.kernel.org/r/CAPgLHd8j_fWcgqe%3DKLWjpBj%2B%3Do0Pw6Z-SEq%3DNTPU08
> c2w1tngQ@...l.gmail.com
> [ Tweaked the error code setting placement and the changelog. ]
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  kernel/events/core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 7b6646a..f6eba58 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -5988,6 +5988,7 @@ skip_type:
>  	if (pmu->pmu_cpu_context)
>  		goto got_cpu_context;
>  
> +	ret = -ENOMEM;
>  	pmu->pmu_cpu_context = alloc_percpu(struct perf_cpu_context);
>  	if (!pmu->pmu_cpu_context)
>  		goto free_dev;
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/