linux-kernel - Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304231714.06326.arnd@arndb.de>
Date:	Tue, 23 Apr 2013 17:14:06 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linus.walleij@...ricsson.com, mian.yousaf.kaukab@...ricsson.com,
	Felipe Balbi <balbi@...com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

On Tuesday 23 April 2013, Lee Jones wrote:
> +Required properties:
> + - compatible : Should be "stericsson,db8500-musb"
> + - reg        : Offset and length of registers
> + - interrupts : Interrupt; mode, number and trigger
> + - mode       : One of; "host", "otg", or "peripheral"

I think we don't have any precedent for this combination of "mode" property
and contents. You could either try to match ehci-omap.txt and do

 - mode : Should be "3" to represent OTG. "1" signifies HOST and "2"
   represents PERIPHERAL.

Or you match fsl-usb.txt and nvidia,tegra20-ehci.txt, defining

 - dr_mode : dual role mode. Indicates the working mode to
   controllers.  Can be "host", "peripheral", or "otg".  Default to
   "host" if not defined for backward compatibility.

> +Optional properties:
> + - dmas       : A list of dma channels;
> +                dma-controller, event-line, fixed-channel, flags
> + - dma-names  : An ordered list of channel names affiliated to the above

Please list the exact dma-names that are required.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/