linux-kernel - Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130423152921.GE15177@arwen.pp.htv.fi>
Date:	Tue, 23 Apr 2013 18:29:21 +0300
From:	Felipe Balbi <balbi@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<balbi@...com>, Lee Jones <lee.jones@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linus.walleij@...ricsson.com>,
	<mian.yousaf.kaukab@...ricsson.com>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

Hi,

On Tue, Apr 23, 2013 at 05:27:10PM +0200, Arnd Bergmann wrote:
> > > > +Required properties:
> > > > + - compatible : Should be "stericsson,db8500-musb"
> > > > + - reg        : Offset and length of registers
> > > > + - interrupts : Interrupt; mode, number and trigger
> > > > + - mode       : One of; "host", "otg", or "peripheral"
> > > 
> > > I think we don't have any precedent for this combination of "mode" property
> > > and contents. You could either try to match ehci-omap.txt and do
> > 
> > there is dr_mode which other folks are using. Let's use the same thing.
> 
> On that topic, should we support the same property in am35x.c and 
> musbhsdma.c? They currently use an integer rather than a string.

certainly :) I also plan to add dr_mode support for dwc3.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)