linux-kernel - Re: eGalax touchscreen regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130423154007.GB4104@core.coreip.homeip.net>
Date:	Tue, 23 Apr 2013 08:40:07 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
Cc:	Hui Wang <jason77.wang@...il.com>,
	Zhang Jiejing <jiejing.zhang@...escale.com>,
	linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hofemeier, Ulf" <ulf.hofemeier@...el.com>
Subject: Re: eGalax touchscreen regression

Hi Artem,

On Tue, Apr 23, 2013 at 12:08:08PM +0300, Artem Bityutskiy wrote:
> Hi Dmitry,
> 
> in the below commit
> 
> commit ae495e844a77344fdaedbb2ad97d925d096e9f0d
> Author: Hui Wang <jason77.wang@...il.com>
> Date:   Thu Oct 25 00:38:01 2012 -0700
> 
>     Input: egalax_ts - get gpio from devicetree
>     
>     The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework
>     and don't support this API anymore.
>     
>     The i.MX6q sabrelite platform equips an egalax touchscreen controller,
>     and this platform already transfered to GENERIC_GPIO framework, to
>     support this driver, we use a more generic way to get gpio.
>     
>     Add a return value checking for waking up the controller in the probe
>     function, this guarantee only a workable device can pass init.
>     
>     [dmitry.torokhov@...il.com: Make driver depend on CONFIG_OF as it is
>      now required.]
>     
>     Acked-by Zhang Jiejing <jiejing.zhang@...escale.com>
>     Reviewed-by: Shawn Guo <shawn.guo@...aro.org>
>     Signed-off-by: Hui Wang <jason77.wang@...il.com>
>     Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> the eGalax driver now requires OF. For us this is a regression because
> we do not have OF: https://bugs.tizen.org/jira/browse/TIVI-740

I see. In this case we need to come up with a platform data to pass
wakeup gpio in case platform does not support OF. irq_to_gpio() is not
supported on many platforms, causing compilation errors.

Is the platform that you are trying to use the touchscreen upstream?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/