linux-kernel - Re: [PATCH 18/21] usb: phy: tegra: don't call into tegra-ehci directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304232102.20573.arnd@arndb.de>
Date:	Tue, 23 Apr 2013 21:02:20 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Venu Byravarasu <vbyravarasu@...dia.com>,
	Felipe Balbi <balbi@...com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Stephen Warren <swarren@...dia.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 18/21] usb: phy: tegra: don't call into tegra-ehci directly

On Tuesday 23 April 2013, Alan Stern wrote:
> On Tue, 23 Apr 2013, Arnd Bergmann wrote:

> > @@ -733,7 +731,9 @@ static int tegra_ehci_probe(struct platform_device *pdev)
> >  
> >  	tegra->phy = tegra_usb_phy_open(&pdev->dev, instance, hcd->regs,
> >  					pdata->phy_config,
> > -					TEGRA_USB_PHY_MODE_HOST);
> > +					TEGRA_USB_PHY_MODE_HOST,
> > +					&tegra_ehci_set_pts,
> > +					tegra_ehci_set_phcd);
> 
> Does the compiler warn about the unnecessary '&'? 

No, AFAIK, both variants are equally acceptable C.

> In any case, it
> looks strange to have one function pointer with an '&' and another
> without.

Yes, that was certainly not intentional. I've removed the '&' now.

> Aside from that minor detail, the ehci-tegra.c changes are fine.

Ok, thanks for the feedback.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/