linux-kernel - Re: question about buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130423201836.GM4068@ZenIV.linux.org.uk>
Date:	Tue, 23 Apr 2013 21:18:36 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: question about buffer_busy check

On Tue, Apr 23, 2013 at 03:41:18PM +0400, Dmitry Monakhov wrote:
> The only guess I have is that this is a miss typo  because buffer
> is busy if some one hold an reference (bh->b_count !=0 )  ||
> it is (dirty | locked). So following patch

... is pointless.  All callers only care about the return value being
zero or non-zero and not about specific values.  Granted, doing it that
way is a micro-optimization, but it's still a valid one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/