linux-kernel - Re: [PATCH -next v2] gpu: host1x: gr2d: fix error return code in gr2d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130424064359.GB1429@avionic-0098.mockup.avionic-design.de>
Date:	Wed, 24 Apr 2013 08:43:59 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	grant.likely@...aro.org, rob.herring@...xeda.com,
	tbergstrom@...dia.com, amerilainen@...dia.com,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH -next v2] gpu: host1x: gr2d: fix error return code in
 gr2d_submit()

On Wed, Apr 24, 2013 at 10:44:08AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return -EINVAL in the host1x_bo lookup error handling
> case instead of 0, as done elsewhere in this function.

So with my comment to v1 addressed this becomes invalid again. I think
in both cases using -ENOENT is a better choice. Pretty much any instance
where drm_gem_object_lookup() fails is handled by returning -ENOENT, so
we should do the same in this driver for consistency.

Thierry

Content of type "application/pgp-signature" skipped