lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Apr 2013 16:54:49 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>, Linus WALLEIJ <linus.walleij@...ricsson.com>, Vinod Koul <vinod.koul@...el.com>, Dan Williams <djbw@...com>, Per Forlin <per.forlin@...ricsson.com>, Rabin Vincent <rabin@....in> Subject: Re: [PATCH 03/32 v2] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s On Thu, Apr 18, 2013 at 2:16 PM, Lee Jones <lee.jones@...aro.org> wrote: > The aim is to make the code that little more readable. > > Cc: Vinod Koul <vinod.koul@...el.com> > Cc: Dan Williams <djbw@...com> > Cc: Per Forlin <per.forlin@...ricsson.com> > Cc: Rabin Vincent <rabin@....in> > Acked-by: Arnd Bergmann <arnd@...db.de> > Signed-off-by: Lee Jones <lee.jones@...aro.org> > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 3b83dee..ddf5ff1 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -49,9 +49,9 @@ > #define MAX_LCLA_ALLOC_ATTEMPTS 256 > > /* Bit markings for allocation map */ > -#define D40_ALLOC_FREE (1 << 31) > -#define D40_ALLOC_PHY (1 << 30) > -#define D40_ALLOC_LOG_FREE 0 > +#define D40_ALLOC_FREE BIT(31) > +#define D40_ALLOC_PHY BIT(30) > +#define D40_ALLOC_LOG_FREE BIT(0) No. 0 != BIT(0) Please fix this... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists