linux-kernel - Re: [PATCH 3/9] pwm: Add Renesas Mobile TPU PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANqRtoQzuBg7Y=zPGPDfmWzKjuR8nGfgEgK43+7uSdivmyaBjg@mail.gmail.com>
Date:	Wed, 24 Apr 2013 18:37:57 +0100
From:	Magnus Damm <magnus.damm@...il.com>
To:	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Cc:	SH-Linux <linux-sh@...r.kernel.org>, linux-leds@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 3/9] pwm: Add Renesas Mobile TPU PWM driver

Hi Laurent,

On Wed, Apr 24, 2013 at 1:06 AM, Laurent Pinchart
<laurent.pinchart+renesas@...asonboard.com> wrote:
> The Timer Pulse Unit (TPU is a 4-channels 16-bit timer used to generate
> waveforms. This driver exposes PWM functions through the PWM API for
> other drivers to use.
>
> The code is loosely based on the leds-renesas-tpu driver by Magnus Damm
> and the TPU PWM driver shipped in the Armadillo EVA 800 kernel sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> Tested-by: Simon Horman <horms@...ge.net.au>
> ---
>  drivers/pwm/Kconfig                    |   7 +
>  drivers/pwm/Makefile                   |   1 +
>  drivers/pwm/pwm-rmob.c                 | 462 +++++++++++++++++++++++++++++++++
>  include/linux/platform_data/pwm-rmob.h |  18 ++
>  4 files changed, 488 insertions(+)
>  create mode 100644 drivers/pwm/pwm-rmob.c
>  create mode 100644 include/linux/platform_data/pwm-rmob.h

Thanks for your efforts with this driver. The new code becomes much
nicer compared to my old driver.

The TPU hardware block is used across several different Renesas
product lines, including R-Mobile and R-Car. So with that in mind, can
you please consider renaming this driver?

I propose pwm-renesas-tpu.c or pwm-tpu.c instead of pwm-rmob.c. This
because this driver has nothing to do with the R mobile product line.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/