linux-kernel - Re: [PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Apr 2013 13:44:51 -0400
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	"Zhang, Rui" <rui.zhang@...el.com>
CC:	Eduardo Valentin <eduardo.valentin@...com>,
	"amit.kachhap@...aro.org" <amit.kachhap@...aro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces

On 24-04-2013 10:48, Zhang, Rui wrote:
>
>
>> -----Original Message-----
>> From: Eduardo Valentin [mailto:eduardo.valentin@...com]
>> Sent: Thursday, April 18, 2013 1:12 AM
>> To: amit.kachhap@...aro.org
>> Cc: Eduardo Valentin; Zhang, Rui; linux-pm@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Subject: [PATCH 02/30] thermal: cpu_cooling: remove trailing white
>> spaces
>> Importance: High
>>
>> Remove unnecessary white spaces.
>>
> The same comments for patch 02, 06, 09, 10, 11, 13, 18, and 30.
>
> Can we run Lindent to fix all the coding style problem in one patch?


Well, yes. The thing about Lindent is that it sometimes changes the code 
in a way we do not want. It will change cpu-cooling in slightly 
different way, but it will include most of the changes on the patches 
above. It misses some of the changes and also does some other that are 
not so nice.

I obviously would prefer to keep these patches, as, the patches are 
already there. Let me know what is your call.

>
> Thanks,
> rui
>> Cc: Zhang Rui <rui.zhang@...el.com>
>> Cc: linux-pm@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>> ---
>>   drivers/thermal/cpu_cooling.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/cpu_cooling.c
>> b/drivers/thermal/cpu_cooling.c index 778c43d..d0d6a0c 100644
>> --- a/drivers/thermal/cpu_cooling.c
>> +++ b/drivers/thermal/cpu_cooling.c
>> @@ -131,14 +131,13 @@ static int get_property(unsigned int cpu,
>> unsigned long input,
>>   	int descend = -1;
>>   	struct cpufreq_frequency_table *table =
>>   					cpufreq_frequency_get_table(cpu);
>> -
>> +
>>   	if (!output)
>>   		return -EINVAL;
>>
>>   	if (!table)
>>   		return -EINVAL;
>>
>> -
>>   	for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) {
>>   		/* ignore invalid entries */
>>   		if (table[i].frequency == CPUFREQ_ENTRY_INVALID)
>> --
>> 1.8.2.1.342.gfa7285d
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/