linux-kernel - Re: [PATCH] re-order CONFIG_EXPERT options to fix menuconfig display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130424130443.7f78a5d78a59d7ed9968cc90@linux-foundation.org>
Date:	Wed, 24 Apr 2013 13:04:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
	zhangwei (Jovi) <jovi.zhangwei@...wei.com>
Subject: Re: [PATCH] re-order CONFIG_EXPERT options to fix menuconfig
 display

On Mon, 22 Apr 2013 13:39:38 -0400 Mike Frysinger <vapier@...too.org> wrote:

> The kconfig language requires that dependent options all follow the
> menuconfig symbol in order to be collapsed below it.  Recently some
> hidden options were added below the EXPERT menuconfig, but did not
> depend on EXPERT (because hidden options can't).  This broke the
> display.  So re-order all these options, and while we're here stick
> the PCI quirks under the EXPERT menu (since it isn't sitting with
> any related options).
> 
> Before this commit, we get:
> 	[*] Configure standard kernel features (expert users)  --->
> 	[ ] Sysctl syscall support
> 	[*] Load all symbols for debugging/ksymoops
> 	...
> 	[ ] Embedded system
> 
> Now we get the older (and correct) behavior:
> 	[*] Configure standard kernel features (expert users)  --->
> 	[ ] Embedded system
> And if you go into the expert menu you get the expert options:
> 	[ ] Sysctl syscall support
> 	[*] Load all symbols for debugging/ksymoops
> 	...
> 

This doesn't work as advertised when I graft it on top of
http://ozlabs.org/~akpm/mmots/broken-out/init-kconfig-make-expert-as-config-instead-of-menuconfig.patch
(generally, assuming that next==mainline when we're at -rc8 is a low
percentage move).

I think I'll drop
init-kconfig-make-expert-as-config-instead-of-menuconfig.patch and take
this one, but could everyone please review everything?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/