linux-kernel - [PATCH/for-next 1/3] iscsi-target: Fix solicited NopIN handling with RDMAExtentions=No

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1366875631-18795-2-git-send-email-nab@linux-iscsi.org>
Date:	Thu, 25 Apr 2013 07:40:29 +0000
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	target-devel <target-devel@...r.kernel.org>
Cc:	linux-rdma <linux-rdma@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Roland Dreier <roland@...nel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: [PATCH/for-next 1/3] iscsi-target: Fix solicited NopIN handling with RDMAExtentions=No

From: Nicholas Bellinger <nab@...ux-iscsi.org>

This patches fixes a regression with solicited NopIN handling
in traditional iSCSI code introduced during TX immediate queue
refactoring for v3.10 for-next code.

Cc: Or Gerlitz <ogerlitz@...lanox.com>
Signed-off-by: Nicholas Bellinger <nab@...ux-iscsi.org>
---
 drivers/target/iscsi/iscsi_target.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 0148cc3..5eee9b7 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3762,12 +3762,6 @@ check_rsp_state:
 		break;
 	case ISTATE_SEND_NOPIN:
 		ret = iscsit_send_nopin(cmd, conn);
-		if (!ret) {
-			spin_lock_bh(&cmd->istate_lock);
-			cmd->i_state = ISTATE_SENT_STATUS;
-			spin_unlock_bh(&cmd->istate_lock);
-			return 0;
-		}
 		break;
 	case ISTATE_SEND_REJECT:
 		ret = iscsit_send_reject(cmd, conn);
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/