lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Apr 2013 11:17:53 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>, Linus WALLEIJ <linus.walleij@...ricsson.com>, Vinod Koul <vinod.koul@...el.com>, Dan Williams <djbw@...com>, Per Forlin <per.forlin@...ricsson.com>, Rabin Vincent <rabin@....in> Subject: Re: [PATCH 14/32] dmaengine: ste_dma40: Remove 'always true' checking On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones <lee.jones@...aro.org> wrote: > Before allocating memory for logical channels, the current driver > checks to see if there are any. Well as the dma40_memcpy_channels[] > array is always populated, the check is always true. Best to > remove the check. > > Cc: Vinod Koul <vinod.koul@...el.com> > Cc: Dan Williams <djbw@...com> > Cc: Per Forlin <per.forlin@...ricsson.com> > Cc: Rabin Vincent <rabin@....in> > Signed-off-by: Lee Jones <lee.jones@...aro.org> (...) > - if (num_log_chans + ARRAY_SIZE(dma40_memcpy_channels)) { So I guess this was changed when moving the memcpy channels into the driver. > - /* > - * The max number of logical channels are event lines for all > - * src devices and dst devices > - */ > - base->lookup_log_chans = kzalloc(num_log_chans * > - sizeof(struct d40_chan *), > - GFP_KERNEL); And at that point you forgot to rewrite this as kzalloc((num_log_chans + ARRAY_SIZE(dma40_memcpy_channels)), ...)? > - if (!base->lookup_log_chans) > - goto failure; > - } > + base->lookup_log_chans = kzalloc(num_log_chans * > + sizeof(struct d40_chan *), > + GFP_KERNEL); > + if (!base->lookup_log_chans) > + goto failure; So this change should also include the memcpy channels. I'll go back and comment again on the patch moving the memcpy channels into the driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists