linux-kernel - RE: [ PATCH ] Memory leak fix for bug 57101.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D2393EB95A9993478029A6FE6A290A9F15F50787@szxeml510-mbx.china.huawei.com>
Date:	Thu, 25 Apr 2013 13:49:12 +0000
From:	Anurup m <anurup.m@...wei.com>
To:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
CC:	"'David Howells'" <dhowells@...hat.com>,
	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	Lizefan <lizefan@...wei.com>, shyju pv <shyju.pv@...wei.com>,
	Sanil kumar <sanil.kumar@...wei.com>,
	Nataraj m <nataraj.m@...wei.com>
Subject: RE: [ PATCH ] Memory leak fix for bug 57101.

Hi All,

Resending the patch as Plain text, with no mangled tabs.

The patch is as below

diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
--- linux-3.9-rc8-vanilla/fs/fscache/stats.c	2013-04-22 03:08:45.000000000 +0530
+++ linux-3.9-rc8.mod/fs/fscache/stats.c	2013-04-24 23:03:31.531296160 +0530
@@ -287,5 +287,5 @@ const struct file_operations fscache_sta
 	.open		= fscache_stats_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release		= seq_release,
+	.release		= single_release,
 };

Regards,
Anurup M

-----Original Message-----
From: Lizefan 
Sent: 2013年4月25日 17:01
To: Anurup m
Cc: 'linux-kernel@...r.kernel.org'; shyju pv; Sanil kumar; Nataraj m
Subject: Re: [ PATCH ] Memory leak fix for bug 57101.

On 2013/4/25 18:05, Anurup m wrote:
> Hi All,
> 
> There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
> The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
> Hence fix with correct release function - single_release. The patch is as below
> 

The fix is obviously corect, but the patch is mangled so you should configure your
email client properly. Read Documention/email-clients.txt.

And when you've done that, remember Cc maintainers when you resend this patch, i.e.
David Howells <dhowells@...hat.com> and Andrew Morton <akpm@...ux-foundation.org>
in this case.

> diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c 
> --- linux-3.9-rc8-vanilla/fs/fscache/stats.c        2013-04-22 03:08:45.000000000 +0530 
> +++ linux-3.9-rc8.mod/fs/fscache/stats.c        2013-04-24 23:03:31.531296160 +0530 
> @@ -287,5 +287,5 @@ const struct file_operations fscache_sta 
>          .open                = fscache_stats_open, 
>          .read                = seq_read, 
>          .llseek                = seq_lseek, 
> -        .release        = seq_release, 
> +        .release        = single_release, 

Look the tab was replaced with spaces.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/