linux-kernel - Re: [PATCHv1] crypto: caam - fix job ring cleanup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130425141856.GC29501@gondor.apana.org.au>
Date:	Thu, 25 Apr 2013 22:18:57 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Horia Geantă <horia.geanta@...escale.com>
Cc:	Vakul Garg <vakul@...escale.com>, linux-crypto@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Kim Phillips <kim.phillips@...escale.com>,
	Bharat Bhushan <bharat.bhushan@...escale.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv1] crypto: caam - fix job ring cleanup code

On Mon, Apr 15, 2013 at 11:58:15AM +0300, Horia Geantă wrote:
> On 4/15/2013 7:25 AM, Vakul Garg wrote:
> >The job ring init function creates a platform device for each job ring.
> >While the job ring is shutdown, e.g. while caam module removal, its
> >platform device was not being removed. This leads to failure while
> >reinsertion and then removal of caam module second time.
> >
> >The following kernel crash dump appears when caam module is reinserted
> >and then removed again. This patch fixes it.
> >
> >root@...80ds:~# rmmod caam.ko
> >Unable to handle kernel paging request for data at address 0x00000008
> >Faulting instruction address: 0xf94aca18
> >Oops: Kernel access of bad area, sig: 11 [#1]
> >SMP NR_CPUS=8 P4080 DS
> >Modules linked in: caam(-) qoriq_dbg(O) [last unloaded: caam]
> >NIP: f94aca18 LR: f94aca18 CTR: c029f950
> >REGS: eac47d60 TRAP: 0300   Tainted: G           O  (3.8.4-rt2)
> >MSR: 00029002 <CE,EE,ME>  CR: 22022484  XER: 20000000
> >DEAR: 00000008, ESR: 00000000
> >TASK = e49dfaf0[2110] 'rmmod' THREAD: eac46000 CPU: 1
> >GPR00: f94ad3f4 eac47e10 e49dfaf0 00000000 00000005 ea2ac210 ffffffff 00000000
> >GPR08: c286de68 e4977ce0 c029b1c0 00000001 c029f950 10029738 00000000 100e0000
> >GPR16: 00000000 10023d00 1000cbdc 1000cb8c 1000cbb8 00000000 c07dfecc 00000000
> >GPR24: c07e0000 00000000 1000cbd8 f94e0000 ffffffff 00000000 ea53cd40 00000000
> >NIP [f94aca18] caam_reset_hw_jr+0x18/0x1c0 [caam]
> >LR [f94aca18] caam_reset_hw_jr+0x18/0x1c0 [caam]
> >Call Trace:
> >[eac47e10] [eac47e30] 0xeac47e30 (unreliable)
> >[eac47e20] [f94ad3f4] caam_jr_shutdown+0x34/0x220 [caam]
> >[eac47e60] [f94ac0e4] caam_remove+0x54/0xb0 [caam]
> >[eac47e80] [c029fb38] __device_release_driver+0x68/0x120
> >[eac47e90] [c02a05c8] driver_detach+0xd8/0xe0
> >[eac47eb0] [c029f8e0] bus_remove_driver+0xa0/0x110
> >[eac47ed0] [c00768e4] sys_delete_module+0x144/0x270
> >[eac47f40] [c000e2f0] ret_from_syscall+0x0/0x3c
> >
> >
> >Signed-off-by: Vakul Garg <vakul@...escale.com>
> >Signed-off-by: Bharat Bhushan <bharat.bhushan@...escale.com>
> >---
> 
> Reviewed-by: Horia Geanta <horia.geanta@...escale.com>

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/