lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.1304251623210.21045@axis700.grange>
Date:	Thu, 25 Apr 2013 16:26:41 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Jiri Kosina <jkosina@...e.cz>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trivial: fix some then vs. than typos

Hi Jiri

On Thu, 25 Apr 2013, Jiri Kosina wrote:

> On Wed, 17 Apr 2013, Guennadi Liakhovetski wrote:
> 
> > This patch fixes some of the obvious then vs. than typos.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> [ ... snip ... ]
> > --- a/Documentation/usb/mass-storage.txt
> > +++ b/Documentation/usb/mass-storage.txt
> > @@ -121,7 +121,7 @@
> >      capped.
> >  
> >      If this parameter is provided, and the number of files specified
> > -    in â??fileâ?? argument is greater then the value of â??lunsâ??, all excess
> > +    in â??fileâ?? argument is greater than the value of â??lunsâ??, all excess
> 
> UTF8 encoding problem?

Yep, looks like that.

> > --- a/arch/blackfin/lib/udivsi3.S
> > +++ b/arch/blackfin/lib/udivsi3.S
> > @@ -66,7 +66,7 @@ ENTRY(___udivsi3)
> >  .Ly_16bit:
> >    /* We know that the upper 17 bits of Y might have bits set,
> >    ** or that the sign bit of X might have a bit. If Y is a
> > -  ** 16-bit number, but not bigger, then we can use the builtins
> > +  ** 16-bit number, but not bigger, than we can use the builtins
> 
> This change is wrong.

Indeed :) As I said, my grepping did return a few false-positives, I 
cleaned up most of them, but missed this one.

Anyway, the patch was incomplete, and perhaps it would be better to split 
it into a series of patches - one per top-level directory to reduce merge 
conflicts. So, maybe someone with better UTF8 and grep / English grammar 
skills could take this over, I won't be requiring any credit for this :)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ