linux-kernel - Re: [PATCH] mfd: vexpress: Handle pending config transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366900849.10438.12.camel@hornet>
Date:	Thu, 25 Apr 2013 15:40:49 +0100
From:	Pawel Moll <pawel.moll@....com>
To:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] mfd: vexpress: Handle pending config transactions

On Thu, 2013-04-25 at 14:02 +0100, Jon Medhurst (Tixy) wrote:
> > +	while (!list_empty(&bridge->transactions)) {
> > +		trans = list_first_entry(&bridge->transactions,
> > +				struct vexpress_config_trans, list);
> >  
> > -		bridge->info->func_exec(trans->func->func, trans->offset,
> > -				trans->write, trans->data);
> > +		vexpress_config_dump_trans("Executing pending", trans);
> > +		status = bridge->info->func_exec(trans->func->func,
> > +				trans->offset, trans->write, trans->data);
> > +
> > +		if (status == VEXPRESS_CONFIG_STATUS_DONE)
> > +			vexpress_config_dump_trans("Finished pending", trans);
> > +		else
> > +			break;
> 
> For each transaction we execute in this loop, don't we also need to do
> the actions vexpress_config_complete does? E.g.
> 
> 	trans->status = status;
> 	list_del(&trans->list);
> 	complete(&trans->completion);
> 
> except in the case status==VEXPRESS_CONFIG_STATUS_WAIT.

You're completely right. I shouldn't have write this code as the last
thing in the afternoon...

Will send v2.

Paweł


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/