linux-kernel - Re: [PATCH v3] usb host: Faraday USB2.0 FUSBH200-HCD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1304251118320.948-100000@iolanthe.rowland.org>
Date:	Thu, 25 Apr 2013 11:20:38 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Yuan-Hsin Chen <yuanlmm@...il.com>
cc:	gregkh@...uxfoundation.org, <sarah.a.sharp@...ux.intel.com>,
	Felipe Balbi <balbi@...com>, <Julia.Lawall@...6.fr>,
	USB list <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, ratbert <ratbert.chuang@...il.com>,
	John Feng-Hsin Chiang(江峰興) 
	<john453@...aday-tech.com>,
	Yuan-Hsin Chen <yhchen@...aday-tech.com>
Subject: Re: [PATCH v3] usb host: Faraday USB2.0 FUSBH200-HCD driver

On Thu, 25 Apr 2013, Yuan-Hsin Chen wrote:

> Hi,
> 
> Are there any comments?

This is okay.  There's just one thing...

> On Tue, Apr 16, 2013 at 8:43 PM, Yuan-Hsin Chen <yuanlmm@...il.com> wrote:
> 
> > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
> > FUSBH200 is an ehci-like controller with some differences.
> > First, register layout of FUSBH200 is incompatible with EHCI.
> > Furthermore, FUSBH200 is lack of siTDs which means iTDs
> > are used for both HS and FS ISO transfer.
> >
> > Signed-off-by: Yuan-Hsin Chen <yhchen@...aday-tech.com>
> > ---
> >
> > v2:
> > use ehci-platform.c
> > use anonymous union and struct
> > add is_fusbh200 to struct ehci_hcd
> >
> > v3:
> > duplicate most of code from Linux-3.8 ehci hcd

> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -287,6 +287,14 @@ config USB_ISP1362_HCD
> >           To compile this driver as a module, choose M here: the
> >           module will be called isp1362-hcd.
> >
> > +config USB_FUSBH200_HCD
> > +       bool "Faraday FUSBH200 HCD support"

Shouldn't this be tristate?

> > +       depends on USB
> > +       default N
> > +       ---help---
> > +       The USB HCD Driver of Faraday FUSBH200 is designed to
> > +       meet USB2.0 EHCI specification with minor modification
> > +

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/