linux-kernel - Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130425153646.GX3658@sgi.com>
Date:	Thu, 25 Apr 2013 10:36:46 -0500
From:	Robin Holt <holt@....com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Robin Holt <holt@....com>, "H. Peter Anvin" <hpa@...or.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Russ Anderson <rja@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.

On Thu, Apr 25, 2013 at 09:34:37AM +0200, Ingo Molnar wrote:
> 
> * Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Thu, 25 Apr 2013 08:57:04 +0200 Ingo Molnar <mingo@...nel.org> wrote:
> > 
> > > > PF_THREAD_BOUND was removed/replaced in linux-next's a9ab775bc
> > > > ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE")
> > > 
> > > I don't see PF_THREAD_BOUND being removed by commit a9ab775bc. Did you 
> > > mean some other commit?
> > 
> > commit 14a40ffccd6163bbcd1d6f32b28a88ffe6149fc6
> > Author: Tejun Heo <tj@...nel.org>
> > Date:   Tue Mar 19 13:45:20 2013 -0700
> > 
> >     sched: replace PF_THREAD_BOUND with PF_NO_SETAFFINITY
> 
> I don't think much action is needed: whenever someone integrates the 
> workqueue tree with these reboot changes, or the workqueue changes hit 
> upstream, a s/PF_THREAD_BOUND/PF_NO_SETAFFINITY should do the trick, 
> right?
> 
> Btw., if that's true then the workqueue tree should probably grow this 
> helper:
> 
> 	#define PF_THREAD_BOUND PF_NO_SETAFFINITY

Andrew, how about I add:
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -155,6 +155,9 @@ static int __init reboot_setup(char *str)
 }
 __setup("reboot=", reboot_setup);
 
+#ifndef PF_THREAD_BOUND
+#define PF_THREAD_BOUND PF_NO_SETAFFINITY
+#endif
 
 static void migrate_to_reboot_cpu(void)
 {

to this patch and then add another patch to the series to remove those.
That will make the stable pull more clear and accomplish the same final
outcome.

Thanks,
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/