linux-kernel - Re: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 18:57:31 +0300
From:	Antti Palosaari <crope@....fi>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach()

On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote:
> drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
> drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function
>
> And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Antti Palosaari <crope@....fi>
Reviewed-by: Antti Palosaari <crope@....fi>


> ---
>   drivers/media/usb/dvb-usb-v2/anysee.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index a20d691..3a1f976 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -638,7 +638,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
>   {
>   	struct anysee_state *state = adap_to_priv(adap);
>   	struct dvb_usb_device *d = adap_to_d(adap);
> -	int ret;
> +	int ret = 0;
>   	u8 tmp;
>   	struct i2c_msg msg[2] = {
>   		{
>


-- 
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/