linux-kernel - Re: [PATCH] futex: bugfix for futex-key conflict when futex use hugepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 22:52:31 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Zhang Yi <wetpzy@....com>
cc:	linux-kernel@...r.kernel.org, dvhart@...ux.intel.com,
	mingo@...nel.org, peterz@...radead.org,
	dave.hansen@...ux.intel.com,
	"zhang.yi20@....com.cn" <zhang.yi20@....com.cn>
Subject: Re: [PATCH] futex: bugfix for futex-key conflict when futex use
 hugepage

On Wed, 24 Apr 2013, Zhang Yi wrote:

> Hi all,
> 
> I reworked the patch base on your advices。
> For the line-wrapped bug before, I use this mailbox to send the mail .

Unfortunately this did not work out very well.

1. Your patch now lacks a proper changelog which explains the change

2. Your patch lacks any newline characters as you can see below
 
> 
> Signed-off-by: Zhang Yi <zhang.yi20@....com.cn>Tested-by: Ma Chenggong <ma.chenggong@....com.cn>Reviewed-by: Liu Dong <liu.dong3@....com.cn>Reviewed-by: Cui Yunfeng <cui.yunfeng@....com.cn>Reviewed-by: Lu Zhongjun <lu.zhongjun@....com.cn>Reviewed-by: Jiang Biao <jiang.biao2@....com.cn>
> 
> diff -uprN orig/linux3.9-rc7/include/linux/futex.h new/linux3.9-rc7/include/linux/futex.h--- orig/linux3.9-rc7/include/linux/futex.h	2013-04-15 00:45:16.000000000 +0000+++ new/linux3.9-rc7/include/linux/futex.h	2013-04-19 16:33:58.725880000 +0000@@ -19,7 +19,7 @@ handle_futex_death(u32 __user *uaddr, st  * The key type depends on whether it's a shared or private mapping.  * Don't rearrange members without looking at hash_futex().  *- * offset is aligned to a multiple of sizeof(u32) (==

Please read Documentation/SubmittingPatches and
Documentation/email-clients.txt. And as I said before: Send the mail
to yourself or a coworker and verify that it can be applied.

Thanks,

	tglx