linux-kernel - Re: [PATCH 1/2] lib: Add lz4 compressor module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20130425154217.c54bd65fba92866c309c94fc@linux-foundation.org>
Date:	Thu, 25 Apr 2013 15:42:17 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Chanho Min" <chanho.min@....com>
Cc:	"'Geert Uytterhoeven'" <geert@...ux-m68k.org>,
	"'Darrick J. Wong'" <djwong@...ibm.com>,
	"'Bob Pearson'" <rpearson@...temfabricworks.com>,
	"'Richard Weinberger'" <richard@....at>,
	"'Herbert Xu'" <herbert@...dor.hengli.com.au>,
	<linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
	"'Yann Collet'" <yann.collet.73@...il.com>,
	"'Kyungsik Lee'" <kyungsik.lee@....com>,
	"'Linux/m68k'" <linux-m68k@...r.kernel.org>,
	"'sparclinux'" <sparclinux@...r.kernel.org>,
	"'Linux-Next'" <linux-next@...r.kernel.org>
Subject: Re: [PATCH 1/2] lib: Add lz4 compressor module

On Mon, 22 Apr 2013 18:22:18 +0900 "Chanho Min" <chanho.min@....com> wrote:

> >> +#define HTYPE const u8*
> >> +
> >> +#ifdef __BIG_ENDIAN
> >> +#define LZ4_NBCOMMONBYTES(val) (__builtin_clz(val) >> 3)
> >> +#else
> >> +#define LZ4_NBCOMMONBYTES(val) (__builtin_ctz(val) >> 3)
> >> +#endif
> >
> >It seems at least m68k and sparc don't have the __builtin_clz() functions:
> >
> >m68k-allmodconfig (http://kisskb.ellerman.id.au/kisskb/buildresult/8572593/):
> >
> >ERROR: "__clzsi2" [lib/lz4/lz4hc_compress.ko] undefined!
> >ERROR: "__clzsi2" [lib/lz4/lz4_compress.ko] undefined!
> 
> gcc seems to define __builtin_clz as __clzsi2 in some architecture. 
> But, kernel doesn't link libgcc.a.
> If kernel should use gcc's built-in function without libgcc.a,
> do we need to port __clzsi2 to 'arch/*/lib/*'?

This breaks alpha (gcc-4.4.4) as well.  Can we please get this fixed
promptly?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/