linux-kernel - Re: [PATCH V3 4/9] mtd: get the ECC info from the Extended Parameter Page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5178CF71.8010302@freescale.com>
Date:	Thu, 25 Apr 2013 14:38:41 +0800
From:	Huang Shijie <b32955@...escale.com>
To:	Brian Norris <computersforpeace@...il.com>
CC:	<dwmw2@...radead.org>, <dedekind1@...il.com>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 4/9] mtd: get the ECC info from the Extended Parameter
 Page

于 2013年04月25日 14:20, Brian Norris 写道:
> No, you cannot do this. Some drivers will provide their own cmdfunc,
> so nand_command_lp() is unexpected for those drivers.
ok. got it.
> Your problem seems, instead, that you are executing this function too
> early, before nand_flash_get_type() is able to assign
yes. This is just the case i meet.
> nand_command_lp() to be your cmdfunc. You might just want to call this
> function after the following lines in nand_flash_get_type():
>
>          /* Do not replace user supplied command function! */
>          if (mtd->writesize>  512&&  chip->cmdfunc == nand_command)
>                  chip->cmdfunc = nand_command_lp;
>
I will send a fix patch about this patch.

thanks
Huang Shijie


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/