linux-kernel - Re: [PATCH V3 0/9] mtd: add datasheet's ECC information to nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN8TOE_5OZ7=hyLn-9hUy9b5ne4HGqra2uAurofB+8kOEuamsw@mail.gmail.com>
Date:	Wed, 24 Apr 2013 23:40:14 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Huang Shijie <b32955@...escale.com>
Cc:	dwmw2@...radead.org, dedekind1@...il.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 0/9] mtd: add datasheet's ECC information to nand_chip{}

Hi Huang,

On Tue, Apr 23, 2013 at 1:54 AM, Huang Shijie <b32955@...escale.com> wrote:
> v2 --> v3:
>         [0] add a new patch to define the semantics of the two fields.
>         [1] Use the Change Read Column command to remove the "last" argument.
>         [2] simplify the onfi_feature().
>         [3] Use kmalloc() to replace kcalloc().
>         [4] others.

Please see especially my comment on your usage of nand_command_lp. But
other than that, I think that by the time we get to v4, this series
should be good. Anyway, I'll try to reserve any more nitpick-y
comments for minor things to my own follow-up patch(es). Thanks for
the work.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/