linux-kernel - [PATCH] msm: iommu: missing platform_driver_unregister() on error in msm_iommu_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAPgLHd_H=4CG95YQf8fdwieNPjXFbHuT_daJ_zDqF94EPzGudQ@mail.gmail.com>
Date:	Thu, 25 Apr 2013 15:12:23 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	ohad@...ery.com, davidb@...eaurora.org, joerg.roedel@....com
Cc:	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org
Subject: [PATCH] msm: iommu: missing platform_driver_unregister() on error in msm_iommu_driver_init()

From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Add the missing platform_driver_unregister() before return
from msm_iommu_driver_init() in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
---
 drivers/iommu/msm_iommu_dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
index 8e8fb07..6b56def 100644
--- a/drivers/iommu/msm_iommu_dev.c
+++ b/drivers/iommu/msm_iommu_dev.c
@@ -402,6 +402,7 @@ static int __init msm_iommu_driver_init(void)
 	ret = platform_driver_register(&msm_iommu_ctx_driver);
 	if (ret != 0) {
 		pr_err("Failed to register IOMMU context driver\n");
+		platform_driver_unregister(&msm_iommu_driver);
 		goto error;
 	}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/