linux-kernel - Re: Basic perf PMU support for Haswell v11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130426065926.GA31487@gmail.com>
Date:	Fri, 26 Apr 2013 08:59:26 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Basic perf PMU support for Haswell v11

* Ingo Molnar <mingo@...nel.org> wrote:

> You say it's barebones, yet it does not work :-( How well was this 
> patch-set tested on non-Haswell hardware, which makes up 99.99% of our 
> installed base?
> 
> In particular, after applying your patches, 'perf top' stopped working 
> on an Intel testbox of mine:

The other problem I noticed was stylistic: when I applied your patches for 
testing even Git complained about their cleanliness ...

To quote from Documentation/SubmittingPatches:

  4) Style check your changes.

  Check your patch for basic style violations, details of which can be
  found in Documentation/CodingStyle.  Failure to do so simply wastes
  the reviewers time and will get your patch rejected, probably
  without even being read.

  At a minimum you should check your patches with the patch style
  checker prior to submission (scripts/checkpatch.pl).  You should
  be able to justify all violations that remain in your patch.

Please make your patches less sloppy!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/