linux-kernel - Re: [tip:x86/efi2] efivars: efivar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <517A4F2A.4080906@intel.com>
Date:	Fri, 26 Apr 2013 10:55:54 +0100
From:	Matt Fleming <matt.fleming@...el.com>
To:	Seiji Aguchi <seiji.aguchi@....com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"jk@...abs.org" <jk@...abs.org>, "teg@...m.no" <teg@...m.no>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mikew@...gle.com" <mikew@...gle.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/efi2] efivars: efivar_entry API

On 24/04/13 00:55, Seiji Aguchi wrote:
> Hi,
> 
> I tested a current tip tree to check if the new API works.
> But pstore_erase() doesn't work...
> I'm checking the source code right now.
> 
> Seiji

[...]

> Call Trace:
>  [<ffffffff8143001f>] efi_pstore_erase+0xdf/0x130
>  [<ffffffff81200038>] ? cap_socket_create+0x8/0x10
>  [<ffffffff811ea491>] pstore_unlink+0x41/0x60
>  [<ffffffff811741ff>] vfs_unlink+0x9f/0x110
>  [<ffffffff8117813b>] do_unlinkat+0x18b/0x280
>  [<ffffffff81178472>] sys_unlinkat+0x22/0x40
>  [<ffffffff81542402>] system_call_fastpath+0x16/0x1b

Does this patch fix things?

---

diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index 47ae712..b820593 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -173,7 +173,7 @@ static int efi_pstore_erase(enum pstore_type_id type, u64 id, int count,
 			    struct timespec time, struct pstore_info *psi)
 {
 	struct pstore_erase_data edata;
-	struct efivar_entry *entry;
+	struct efivar_entry *entry = NULL;
 	char name[DUMP_NAME_LEN];
 	efi_char16_t efi_name[DUMP_NAME_LEN];
 	int found, i;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/