linux-kernel - RE: [tip:x86/efi2] efivars: efivar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 15:05:46 +0000
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Matt Fleming <matt.fleming@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"jk@...abs.org" <jk@...abs.org>, "teg@...m.no" <teg@...m.no>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mikew@...gle.com" <mikew@...gle.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: RE: [tip:x86/efi2] efivars: efivar_entry API

It worked with this fix.
Thanks!

Seiji

> -----Original Message-----
> From: Matt Fleming [mailto:matt.fleming@...el.com]
> Sent: Friday, April 26, 2013 10:55 AM
> To: Seiji Aguchi
> Cc: linux-kernel@...r.kernel.org; mingo@...nel.org; hpa@...or.com; mjg59@...f.ucam.org; tony.luck@...el.com; jk@...abs.org;
> teg@...m.no; tglx@...utronix.de; mikew@...gle.com; linux-tip-commits@...r.kernel.org
> Subject: Re: [tip:x86/efi2] efivars: efivar_entry API
> 
> On 26/04/13 15:25, Seiji Aguchi wrote:
> > Matt,
> >
> > Thanks.
> > With your patch, It works in case each entry is erased one by one as below.
> > # rm dmesg-efi-1
> > #rm dmesg-efi-2
> 
> How about if you add this to efi_pstore_erase_func()?
> 
> ---
> 
> diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
> index b820593..393d63a 100644
> --- a/drivers/firmware/efi/efi-pstore.c
> +++ b/drivers/firmware/efi/efi-pstore.c
> @@ -166,6 +166,7 @@ static int efi_pstore_erase_func(struct efivar_entry *entry, void *data)
> 
>  	/* found */
>  	__efivar_entry_delete(entry);
> +	list_del(&entry->list);
>  	return 1;
>  }
>