linux-kernel - RE: [nhorman@...driver.com: [PATCH] libcxgbi: supress warning when we request to much space from kmalloc]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8A71B368A89016469F72CD08050AD3340CBE8487@maui.asicdesigners.com>
Date:	Fri, 26 Apr 2013 08:20:53 -0700
From:	"Karen Xie" <kxie@...lsio.com>
To:	<linux-scsi@...r.kernel.org>
Cc:	"Neil Horman" <nhorman@...driver.com>, <JBottomley@...allels.com>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [nhorman@...driver.com: [PATCH] libcxgbi: supress warning when we request to much space from kmalloc]

-----Original Message-----
From: Neil Horman [mailto:nhorman@...driver.com] 
Sent: Friday, April 26, 2013 4:02 AM
To: Karen Xie
Subject: [nhorman@...driver.com: [PATCH] libcxgbi: supress warning when
we request to much space from kmalloc]

The patch looks fine to me.

Thanks,
Karen
----- Forwarded message from Neil Horman <nhorman@...driver.com> -----

Date: Tue, 23 Apr 2013 11:20:47 -0400
From: Neil Horman <nhorman@...driver.com>
To: linux-scsi@...r.kernel.org
Cc: Neil Horman <nhorman@...driver.com>, "James E.J. Bottomley"
<JBottomley@...allels.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] libcxgbi: supress warning when we request to much space
from kmalloc
X-Mailer: git-send-email 1.8.1.4

cxgbi_alloc_big_mem allocates large chunks of memory, and can
occasionally request amounts from kmalloc that exceed the allocators
capacity.  This typically leads to a stack trace from the zoned buddy
allocator in the message log.  But if kmalloc fails, cxgbi_alloc_big_mem
backs off and uses vmalloc instead.  Given that, and the fact that the
two calls sites have their own error messages if both kmalloc and
vmalloc fail, I think the stack trace printing isn't really needed.

Modify the call to kmalloc to pass __GFP_NOWARN in as well, so that
internal kmalloc warnings are suppressed.

Signed-off-by: Neil Horman <nhorman@...driver.com>
Reported-by: Honggang LI <honli@...hat.com>
CC: "James E.J. Bottomley" <JBottomley@...allels.com>
CC: linux-kernel@...r.kernel.org
---
 drivers/scsi/cxgbi/libcxgbi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.h
b/drivers/scsi/cxgbi/libcxgbi.h index 80fa99b..3daf996 100644
--- a/drivers/scsi/cxgbi/libcxgbi.h
+++ b/drivers/scsi/cxgbi/libcxgbi.h
@@ -658,7 +658,7 @@ static inline u32 cxgbi_tag_nonrsvd_bits(struct
cxgbi_tag_format *tformat,  static inline void
*cxgbi_alloc_big_mem(unsigned int size,
 					gfp_t gfp)
 {
-	void *p = kmalloc(size, gfp);
+	void *p = kmalloc(size, gfp | __GFP_NOWARN);
 	if (!p)
 		p = vmalloc(size);
 	if (p)
--
1.8.1.4

----- End forwarded message -----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/