linux-kernel - Re: eGalax touchscreen regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130426153911.GA18528@core.coreip.homeip.net>
Date:	Fri, 26 Apr 2013 08:39:11 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Hui Wang <jason77.wang@...il.com>,
	Zhang Jiejing <jiejing.zhang@...escale.com>,
	linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hofemeier, Ulf" <ulf.hofemeier@...el.com>
Subject: Re: eGalax touchscreen regression

On Fri, Apr 26, 2013 at 06:09:05PM +0300, Artem Bityutskiy wrote:
> On Fri, 2013-04-26 at 16:59 +0200, Arnd Bergmann wrote:
> > On Wednesday 24 April 2013 12:03:13 Artem Bityutskiy wrote:
> > > On Tue, 2013-04-23 at 08:40 -0700, Dmitry Torokhov wrote:
> > > > > the eGalax driver now requires OF. For us this is a regression because
> > > > > we do not have OF: https://bugs.tizen.org/jira/browse/TIVI-740
> > > > 
> > > > I see. In this case we need to come up with a platform data to pass
> > > > wakeup gpio in case platform does not support OF. irq_to_gpio() is not
> > > > supported on many platforms, causing compilation errors.
> > > > 
> > > > Is the platform that you are trying to use the touchscreen upstream?
> > > 
> > > OK, so this is about just a monitor with a touchscreen (Giantec high-res
> > > capacitive 11.6” LCD monitor). The touchscreen is connected to a
> > > commodity hardware via USB.
> > > 
> > > So yes, the platform _is_ upstream  Namely, we use just a SandyBridge
> > > PC.
> > 
> > So you use a usb-to-i2c interface?
> 
> I do not think so. The problem is that I do not have the HW, so I was
> making guesses, and it looks like this driver has nothing to do with the
> regression we've got. Sorry for the noise. We'll investigate this more
> carefully internally.

OK, so assuming you simply using USB version of eGalax device the only
recent change (3.6-rc7) was:

commit 037a833ed05a86d01ea27a2c32043b86c549be1b
Author: Forest Bond <forest.bond@...idrollout.com>
Date:   Tue Sep 4 20:27:37 2012 -0700

    Input: usbtouchscreen - initialize eGalax devices
    
    Certain eGalax devices expose an interface with class HID and protocol
    None.  Some work with usbhid and some work with usbtouchscreen, but
    there is no easy way to differentiate.  Sending an eGalax diagnostic
    packet seems to kick them all into using the right protocol for
    usbtouchscreen, so we can continue to bind them all there (as opposed to
    handing some off to usbhid).
    
    This fixes a regression for devices that were claimed by (and worked
    with) usbhid prior to commit 139ebe8dc80dd74cb2ac9f5603d18fbf5cff049f
    ("Input: usbtouchscreen - fix eGalax HID ignoring"), which made
    usbtouchscreen claim them instead.  With this patch they will still be
    claimed by usbtouchscreen, but they will actually report events
    usbtouchscreen can understand.  Note that these devices will be limited
    to the usbtouchscreen feature set so e.g. dual touch features are not
    supported.
    
    I have the distinct pleasure of needing to support devices of both types
    and have tested accordingly.
    
    Signed-off-by: Forest Bond <forest.bond@...idrollout.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/