linux-kernel - Re: [PATCH v2 2/3] ASoC: spdif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <517AD46A.2020402@gmail.com>
Date:	Fri, 26 Apr 2013 21:24:26 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Marek Belisko <marek.belisko@...il.com>
CC:	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	rob@...dley.net, alsa-devel@...a-project.org,
	Michal Bachraty <michal.bachraty@...eamunlimited.com>,
	linux-doc@...r.kernel.org, tiwai@...e.de,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	broonie@...nel.org,
	Marek Belisko <marek.belisko@...eamunlimited.com>,
	perex@...ex.cz
Subject: Re: [PATCH v2 2/3] ASoC: spdif_transmitter: Add DT support.

On 04/25/2013 03:13 PM, Marek Belisko wrote:
> Add devicetree support for this dummy audio soc driver.
>
> Signed-off-by: Michal Bachraty<michal.bachraty@...eamunlimited.com>
> Signed-off-by: Marek Belisko<marek.belisko@...eamunlimited.com>
> ---
>   .../bindings/sound/spdif-transmitter.txt           |   10 ++++++++++
>   sound/soc/codecs/spdif_transmitter.c               |   10 ++++++++++
>   2 files changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/spdif-transmitter.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
> new file mode 100644
> index 0000000..55a8584
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
> @@ -0,0 +1,10 @@
> +Device-Tree bindings for dummy spdif transmitter
> +
> +Required properties:
> +	- compatible: should be "linux,spdif-dit".

Marek,

I remember Daniel commenting on the name already, but
what about "spdif-transmitter" and "spdif-receiver" respectively?
That is very generic and should allow to remove "linux," prefix.
And there is a lot of drivers using more informative compatible
strings compared to the driver name.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/