| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPgLHd_ukrA6hqiRAmik_MJ3eew4LmOCB2uJtZWm7D0CtbRt9g@mail.gmail.com> Date: Fri, 26 Apr 2013 14:17:46 +0800 From: Wei Yongjun <weiyj.lk@...il.com> To: zbr@...emap.net, neilb@...e.de, gregkh@...uxfoundation.org Cc: yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org Subject: [PATCH] w1: ds2780: fix the error handling in w1_ds2780_add_slave() From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn> Use platform_device_put() instead of platform_device_unregister() if platform_device_add() fail, and platform_device_del() should be used in the error handling case after platform_device_add() success. Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn> --- drivers/w1/slaves/w1_ds2780.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2780.c b/drivers/w1/slaves/w1_ds2780.c index 7b09307..98ed9c4 100644 --- a/drivers/w1/slaves/w1_ds2780.c +++ b/drivers/w1/slaves/w1_ds2780.c @@ -141,8 +141,9 @@ static int w1_ds2780_add_slave(struct w1_slave *sl) return 0; bin_attr_failed: + platform_device_del(pdev); pdev_add_failed: - platform_device_unregister(pdev); + platform_device_put(pdev); pdev_alloc_failed: ida_simple_remove(&bat_ida, id); noid: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists