linux-kernel - Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130427131715.GB32432@kroah.com>
Date:	Sat, 27 Apr 2013 06:17:15 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Qiaowei Ren <qiaowei.ren@...el.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Richard L Maliszewski <richard.l.maliszewski@...el.com>,
	Shane Wang <shane.wang@...el.com>,
	Gang Wei <gang.wei@...el.com>, linux-kernel@...r.kernel.org,
	Xiaoyan Zhang <xiaoyan.zhang@...el.com>
Subject: Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log

On Sat, Apr 27, 2013 at 10:56:18PM +0800, Qiaowei Ren wrote:
> +ssize_t sysfs_create_log(struct kobject *parent)
> +{
> +	struct kobject *log_kobj;
> +	int retval;
> +
> +	log_kobj = kobject_create_and_add("log", parent);
> +	if (!log_kobj)
> +		return -ENOMEM;
> +
> +	retval = sysfs_create_group(log_kobj, &log_attr_grp);
> +	if (retval)
> +		kobject_put(log_kobj);
> +	return retval;
> +}
> +EXPORT_SYMBOL_GPL(sysfs_create_log);

Seriously?  That's what you are calling this function?

{sigh}

Please, go get this patch series reviewed by other, experienced, Intel
developers, before you send it out again.  There's loads of things wrong
with this series, and they can help you out much easier, and nicer, than
I'm going to be here.

Oh, and NEVER use "raw" kobjects, by doing that, you know you are doing
something wrong in a driver.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/